[PATCH] cmdutil: rename '_deleted' to 'deleted' since it is used

Pierre-Yves David pierre-yves.david at ens-lyon.org
Fri Oct 3 15:10:57 CDT 2014



On 10/03/2014 03:09 PM, Matt Mackall wrote:
> On Fri, 2014-10-03 at 14:48 -0500, Pierre-Yves David wrote:
>>
>> On 10/03/2014 01:50 PM, Martin von Zweigbergk wrote:
>>> # HG changeset patch
>>> # User Martin von Zweigbergk <martinvonz at gmail.com>
>>> # Date 1412362128 25200
>>> #      Fri Oct 03 11:48:48 2014 -0700
>>> # Node ID 27a6af7fdd92f97cd587faae9502c044b292fb83
>>> # Parent  78c916f24dd99a56e4c29153a5df3bd7d1c40edd
>>> cmdutil: rename '_deleted' to 'deleted' since it is used
>>>
>>> Underscore seems to be used as a prefix in some places to indicate
>>> that a variable is not used, so avoid using it for a variable that is
>>> used.
>>
>>
>> No thanks, The variable is only used in the direct vicinity for a quick
>> computation. The other have a great destiny much lower in the rest of
>> this hug function.
>
> Totally confusing to me until I realized that 'hug' is probably a
> reference to the 'hugs' Haskell compiler and that he's manually
> implementing static single assignment.
>
> (https://en.wikipedia.org/wiki/Static_single_assignment_form)

s/hug/huge/

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list