[PATCH] repoview: disable hiddencache verification on default

[Augie Fackler]

On Mon, Oct 06, 2014 at 08:06:15AM -0700, David Soria Parra wrote:
> # HG changeset patch
> # User David Soria Parra <davidsp at fb.com>
> # Date 1412605780 25200
> #      Mon Oct 06 07:29:40 2014 -0700
> # Node ID 7f98bcb9e6b8ff7985998507d0a51e6778ab5bc2
> # Parent  44dce874de97a2b3d47cc8be97432cbfcffddbe1
> repoview: disable hiddencache verification on default
>
> We have been running hiddencache verification since 3.1.1 and so
> far not received a bug report concerning it. Therefore we remove
> the verification code and make the hiddencache authoritive. That
> way we get the intended speedup.
>
> diff --git a/mercurial/repoview.py b/mercurial/repoview.py
> --- a/mercurial/repoview.py
> +++ b/mercurial/repoview.py
> @@ -138,14 +138,6 @@
>              blocked = cl.ancestors(_getstaticblockers(repo), inclusive=True)
>              hidden = frozenset(r for r in hideable if r not in blocked)
>              trywritehiddencache(repo, hideable, hidden)
> -        elif repo.ui.configbool('experimental', 'verifyhiddencache', True):

We could also make the default False for a cycle, so that if someone
has a problem we can turn it back on? Or are we not worried about that
now?

> -            blocked = cl.ancestors(_getstaticblockers(repo), inclusive=True)
> -            computed = frozenset(r for r in hideable if r not in blocked)
> -            if computed != hidden:
> -                trywritehiddencache(repo, hideable, computed)
> -                repo.ui.warn(_('Cache inconsistency detected. Please ' +
> -                    'open an issue on http://bz.selenic.com.\n'))
> -                hidden = computed
>
>          # check if we have wd parents, bookmarks or tags pointing to hidden
>          # changesets and remove those.
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel