[PATCH 1 of 5 V2] parsers: add a function to efficiently lowercase ASCII strings

Siddharth Agarwal sid at less-broken.com
Tue Oct 7 12:12:55 CDT 2014


On 10/07/2014 10:00 AM, Augie Fackler wrote:
> +try:
> +    asciilower = parsers.asciilower
> could spell this as
>
> asciilower = getattr(parsers, 'asciilower', asciilower)
>
> Does that make you feel better?
<snip>
>> +	{"asciilower", asciilower, METH_VARARGS, "lowercase if ASCII\n"},
> Perhaps "lowercase an ASCII string" for the docstring?

Sure, both of these are good to me. Want to address them inflight?


More information about the Mercurial-devel mailing list