[PATCH 1 of 5 V2] parsers: add a function to efficiently lowercase ASCII strings
Augie Fackler
raf at durin42.com
Tue Oct 7 12:18:55 CDT 2014
On Tue, Oct 7, 2014 at 1:12 PM, Siddharth Agarwal <sid at less-broken.com> wrote:
> On 10/07/2014 10:00 AM, Augie Fackler wrote:
>>
>> +try:
>> + asciilower = parsers.asciilower
>> could spell this as
>>
>> asciilower = getattr(parsers, 'asciilower', asciilower)
>>
>> Does that make you feel better?
>
> <snip>
>>>
>>> + {"asciilower", asciilower, METH_VARARGS, "lowercase if ASCII\n"},
>>
>> Perhaps "lowercase an ASCII string" for the docstring?
>
>
> Sure, both of these are good to me. Want to address them inflight?
If you mean you'll fix those and then clowncopterize, please do (but
ping this thread when done, and I'll twiddle patchwork appropriately.)
More information about the Mercurial-devel
mailing list