[PATCH 1 of 3 manifest-cleanup] manifest: move manifestdict-to-text encoding to manifest class

Augie Fackler raf at durin42.com
Thu Oct 9 13:15:41 CDT 2014

On Thu, Oct 9, 2014 at 1:59 PM, Durham Goode <durham at fb.com> wrote:
>>where this is going (I wanted feedback on this interface relatively
>>early, since I'm hoping it needs only minor tweaks and I'd like to
>>avoid extra churn.)
> Do you have any document (or list in your head) with what the final
> interface might look like after everything is moved?  It¹s hard to get a
> feel for the interface when seeing individual functions getting moved
> piece by piece.

So, as far as I can tell, the interface is going to remain the same
from the perspective of most commands. The only tweak I expect in what
I have now is that the .text() and .fastdelta() methods on manifest
classes will need some way to return the expected object hash, so that
can be passed on to the revlog layer, and we might need to do some
clever hash-function-injection into the lower layer as well.

Does that answer your question?

More information about the Mercurial-devel mailing list