[PATCH 1 of 2 v2] localrepo: persistent caching of branch names

Mads Kiilerich mads at kiilerich.com
Wed Oct 15 20:24:17 CDT 2014


On 10/15/2014 09:02 PM, Augie Fackler wrote:
> On Wed, Oct 15, 2014 at 2:57 PM, Mads Kiilerich <mads at kiilerich.com> wrote:
>> On 10/15/2014 08:32 PM, Augie Fackler wrote:
>>> On Wed, Oct 15, 2014 at 08:14:22PM +0200, Mads Kiilerich wrote:
>>>> I can't say I'm a fan of the None/False/True three-state boolean thing
>>>> going on here. Can we do better somehow? Perhaps by moving the
>>>> branchcache into its own object rather than wedging it into
>>>> repofilecache?
>> Doing it that way would add an extra indirection and we do not like classes.
> Says who? We've been growing more of them as it makes sense, and I
> think this is one of those cases where it makes a /ton/ of sense.

http://mercurial.selenic.com/wiki/CodingStyle#Classes

/Mads


More information about the Mercurial-devel mailing list