[PATCH 7 of 7 V3] bundle2: client side support for a part to import external bundles

[Mike Hommey]

On Thu, Oct 16, 2014 at 03:07:12AM -0700, Pierre-Yves David wrote:
> I'm not sure how the changegroup type is handled here. Does it -has- to be
> HG10 or another variant (coming HG11 would work too?) If not you want to
> grow a "version" parameter as the b2x:changegroup part did.

There is an instance check against changegroup.cg1unpacker, whatever
that means. If HG11 bundles end up returning a changegroup.cg1unpacker
object, then they'll be accepted. OTOH, the client would need to tell the
server what versions it supports (more than the server needs to tell the
client what bundle version it is).

> >+    lines = []
> >+    try:
> >+        url = inpart.params['url']
> >+    except KeyError:
> >+        raise util.Abort(_('remote-changegroup: missing "%s" param') % 'url')
> 
> We have some exception dedicated to "This bundle2 is valid but crap" we
> should use them instead. (not sure exactly how mature it is)

Where should I look for that?

Mike