[PATCH 6 of 9] histedit: pass state to processreplacement

[David Soria Parra]

Olle <olle.lundberg at gmail.com> writes:

> On Thu, Oct 16, 2014 at 7:34 PM, David Soria Parra <davidsp at fb.com>
> wrote:
>
>     # HG changeset patch
>     # User David Soria Parra <davidsp at fb.com>
>     # Date 1413479209 25200
>     # Thu Oct 16 10:06:49 2014 -0700
>     # Node ID 638453c54662a68d4243976c36712f0ac3ea272d
>     # Parent cbe0c2c08822ca9a36463c385601ecd9a5bb53e2
>     histedit: pass state to processreplacement
>     
>     diff --git a/hgext/histedit.py b/hgext/histedit.py
>     --- a/hgext/histedit.py
>     +++ b/hgext/histedit.py
>     @@ -572,8 +572,7 @@
>     state = bootstrapcontinue(ui, state, opts)
>     elif goal == 'abort':
>     state = readstate(repo)
>     - mapping, tmpnodes, leafs, _ntm = processreplacement(repo,
>     - state.replacements)
>     + mapping, tmpnodes, leafs, _ntm = processreplacement(repo, state)
> The repo parameter becomes unnecessary here since you keep a reference
> to the repo in the state object being sent in?
> For consistencies sake it would be nice if you could assign it like in
> patch cbe0c2c08822ca9a36463c385601ecd9a5bb53e2

good catch. will wait for augie and pierre-yves to review the rest of
the series and send a v2 with that change