[PATCH] lock: while releasing, unlink lockfile even if the release function throws

Pierre-Yves David pierre-yves.david at ens-lyon.org
Thu Oct 16 21:48:53 CDT 2014



On 10/16/2014 07:39 PM, Siddharth Agarwal wrote:
> # HG changeset patch
> # User Siddharth Agarwal <sid0 at fb.com>
> # Date 1413512151 25200
> #      Thu Oct 16 19:15:51 2014 -0700
> # Node ID 973c86a609dd4d30b351bc5fa2210c380c7d04d1
> # Parent  840be5ca03e1db16ba994e55597771c418166c97
> lock: while releasing, unlink lockfile even if the release function throws

The patch sound sensible, but I'll give it a second though in a couple 
of hours because it the area is sensitive.

Is it possible to produce an appropriate test for this (that does no 
deadlock when failing) so we do not regress this in the future?

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list