[PATCH 4 of 4 STABLE] context.status: remove overriding in workingctx

[Matt Mackall]

On Thu, 2014-10-23 at 14:39 -0700, Martin von Zweigbergk wrote:
> # HG changeset patch
> # User Martin von Zweigbergk <martinvonz at google.com>
> # Date 1414097000 25200
> #      Thu Oct 23 13:43:20 2014 -0700
> # Branch stable
> # Node ID 47d1e211f68485ad2070fb505966edf34178a564
> # Parent  2eb04f88de4b5103fb3c3584811b557b3ec2b771
> context.status: remove overriding in workingctx
> 
> The workingctx method simply calls the super method. The only effect
> it has is that it uses a different default argument for the 'other'
> argument. The only in-tree caller is patch.diff, which always passes
> an argument to the method, so it should be safe to remove the
> overriding. Having the default argument depend on the type seems
> rather dangerous anyway.

For future reference, the goal of the stable branch is to maximize:

 user benefit / user risk

..so "cleanups" don't belong. At best, they have no user impact. At
worst, they introduce inadvertent breakage.

-- 
Mathematics is the supreme nostalgia of our time.