[PATCH 1 of 3 STABLE v2] tests: add test for failing bookmark push code

[Pierre-Yves David]

On 10/25/2014 01:19 AM, Gregory Szorc wrote:
> On 10/24/14 3:41 PM, Pierre-Yves David wrote:
>>
>>
>> On 10/24/2014 08:07 PM, Gregory Szorc wrote:
>>> # HG changeset patch
>>> # User Gregory Szorc <gregory.szorc at gmail.com>
>>> # Date 1414171261 25200
>>> #      Fri Oct 24 10:21:01 2014 -0700
>>> # Branch stable
>>> # Node ID 8344ea64087d5eaab42709aaab6daa38dbde3db8
>>> # Parent  eb763217152ab2b472416bcc57722451c317f282
>>> tests: add test for failing bookmark push code
>>>
>>> b901645a8784 regressed the behavior of pushing an unchanged bookmark to
>>> a remote. Before that commit, pushing a unchanged bookmark would result
>>> in "exporting bookmark @" being printed. After that commit, we now see
>>> an incorrect message "bookmark %s does not exist on the local or remote
>>> repository!"
>>
>> I would argue that the "exporting bookmark X" is from if no change is
>> actually made to the bookmark.
>
> I considered this. But I wanted to write a backward-compatible patch to
> minimize contention and increase chances of making 3.2.

I would argue that this "exporting bookmark @" when nothing is actually 
moved is a bug and worthy of fixing on stable.

-- 
Pierre-Yves David