[PATCH 2 of 3] config: give a more detailed sample repo config

Jordi Gutiérrez Hermoso jordigh at octave.org
Wed Sep 3 09:11:01 CDT 2014


On Tue, 2014-09-02 at 21:09 +0200, Pierre-Yves David wrote:
> 
> On 08/27/2014 02:13 AM, Jordi Gutiérrez Hermoso wrote:
> > On Tue, 2014-08-26 at 22:59 +0200, Pierre-Yves David wrote:
> >>
> >> On 08/25/2014 01:51 AM, Jordi Gutiérrez Hermoso wrote:
> >>> # HG changeset patch
> >>> # User Jordi Gutiérrez Hermoso <jordigh at octave.org>
> >>> # Date 1408923803 14400
> >>> #      Sun Aug 24 19:43:23 2014 -0400
> >>> # Node ID 12718916f03b4a917609ecf41bb8d93fbd1024ca
> >>> # Parent  cfec84ed3d8f5b9877f48ec079eb0583b51f56ad
> >>> config: give a more detailed sample repo config
> >>>
> >>> Some examples of the typical configurations that one might want to do
> >>> in an .hg/hgrc file.
> >>
> >> Still not trace of the obvious candidate "default-push"
> >
> > I honestly find that a bit too specialised for a simple example hgrc.
> > I think people are more likely to want to know about local and remote
> > clones. A fourth example path already seems too cluttered.
> > Personally, I never use default-push.
> 
> default-push saved the life of multiple of my logilabian by preventing 
> them to push to the wrong repo by mistake. I feel like it is a valid 
> example because it make a feature discoverable. Most people will not 
> suspect it ever exist otherwise

Okay, I'll add it.

> I'm still not super fan of the `myxxx` names. It may just be that is 
> read like `phpmyeditconfig` to me.

Okay, I can change these names, but we already have a precedence for
"my_path" in the paths section of `hg help hgrc`.

> If you do not like having more than three, we could maybe drop one of 
> them in favor of default-push.

Maybe a tiny bit of clutter will be ok.

> You should also put a reference to the documentation and a small comment 
> to highlight we have reserved name (default) with special meaning and 
> also arbitrary ones.

I wish it were possible to give a reference to a particular section of
`hg help hgrc`, which is a rather long document.

> Seeing a new version of a patch that does not apply your review
> comment and mention nothing about them is quite anoying.

Sorry, I'll try to annoy you less.

Should I resend the entire series?

- Jordi G. H.




More information about the Mercurial-devel mailing list