[PATCH STABLE] ignore python folder included within hackable hg packages

Adrian Buehlmann adrian at cadifra.com
Tue Sep 9 16:19:24 CDT 2014


On 2014-09-09 22:45, Steve Borho wrote:
> On 09/09, Adrian Buehlmann wrote:
>> On 2014-09-09 20:44, Steve Borho wrote:
>>> the hg-python/ path is only checked when PYTHONHOME is found in the environment,
>>
>> Are you sure?
> 
> Ahh. GetEnvironmentVariable returns 0 on failure. I should not have guessed.
> 
> While I have your attention, why is PYTHONHOME considered in this
> function at all, if its contents are ignored? Please explain how this
> was intended to work.
> 

It's been too long since I hacked on that stuff to really remember, but
I think that the python interpreter (call of Py_Main in exewrapper.c)
will interpret PYTHONHOME if it is set and I think the idea was that it
doesn't make sense to interfere with that, iff PYTHONHOME is set. After
all, if somebody sets PYTHONHOME then she probably knows where the
python libs are.

Perhaps setting PYTHONHOME was used on the buildbot [1] or something
like that. I can't remember any more.

[1] http://mercurial.selenic.com/wiki/Buildbot (which looks down-ish..)


More information about the Mercurial-devel mailing list