[PATCH 01 of 21 RFC] changegroup: inline builddeltaheader, public method only called once

Pierre-Yves David pierre-yves.david at ens-lyon.org
Thu Sep 11 07:12:18 CDT 2014



On 09/11/2014 02:26 AM, michaeljedgar at gmail.com wrote:
> # HG changeset patch
> # User Mike Edgar <adgar at google.com>
> # Date 1409521580 -7200
> #      Sun Aug 31 23:46:20 2014 +0200
> # Node ID 44e926f8ae03bc1e0822c282a77538a875353ecf
> # Parent  f08b657130b9ac7cd2ad27afea6895dfde7d7722
> changegroup: inline builddeltaheader, public method only called once
>
> This helper also had an unused argument, possibly left over from an API
> migration. This change should be a no-op; I've left in the calculation of the
> unused base node as it could raise an exception if the base isn't present.

Bad pick. The change is not left over from an API migration. The change 
is an unfinished migration. The goal here is to provide a second type of 
changegroup that will support general delta. We are very close to get 
that as Sune Foldager is currently actively working on it.

For your credit, this migration is on going for years… You probably want 
to synchronise with him.


-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list