[PATCH 1 of 2] histedit: add execute method

David Soria Parra dsp at experimentalworks.net
Tue Sep 16 19:36:53 CDT 2014


Durham Goode <durham at fb.com> writes:

> On 9/16/14, 2:23 PM, David Soria Parra wrote:
>> +    if process.returncode != 0:
>> +        raise error.InterventionRequired(
>> +            _("Command '%s' failed with exit status %d.") % (cmd,
>> +                process.returncode))
>> +    if util.any(repo.status()[:4]):
>> +        raise error.InterventionRequired(
>> +            _('Working copy dirty, please check the files listed above.\n'
>> +              'When you are finished, run hg histedit --continue to resume.'))
>> +    return ctx, []
> Don't we need to return repo['.'] as the new context?  And potentially
> provide a mapping from ctx.node() to newctx.node() (assuming ctx isn't
> a descendant of newctx)?  That way we can handle them
> adding/modifying/deleting commits during the exec.

good point, i'll send a v2.


More information about the Mercurial-devel mailing list