[PATCH 2 of 3] revsetbenchmark: allow comment ('#' prefix) in the revset input

Augie Fackler raf at durin42.com
Wed Sep 24 09:10:21 CDT 2014


On Tue, Sep 23, 2014 at 08:06:43PM -0700, Pierre-Yves David wrote:
>
>
> On 09/23/2014 06:49 PM, Sean Farley wrote:
> >
> >Pierre-Yves David writes:
> >
> >># HG changeset patch
> >># User Pierre-Yves David <pierre-yves.david at fb.com>
> >># Date 1411517359 25200
> >>#      Tue Sep 23 17:09:19 2014 -0700
> >># Node ID d557d5e8020445bdc3ab5f5b0763eca00d111c04
> >># Parent  b0b9aadb625d62922eb6dae164b9934f314807db
> >>revsetbenchmark: allow comment ('#' prefix) in the revset input
> >>
> >>diff --git a/contrib/revsetbenchmarks.py b/contrib/revsetbenchmarks.py
> >>--- a/contrib/revsetbenchmarks.py
> >>+++ b/contrib/revsetbenchmarks.py
> >>@@ -92,11 +92,11 @@ target_rev = args[0]
> >>
> >>  revsetsfile = sys.stdin
> >>  if options.file:
> >>      revsetsfile = open(options.file)
> >>
> >>-revsets = [l.strip() for l in revsetsfile]
> >>+revsets = [l.strip() for l in revsetsfile if not l.startswith('l')]
> >
> >Am I missing something or is 'l' a typo?
>
> Looks like I forgot an amend somewhere…
>
>   New programming trend, "l" as a comment prefix!
>
> Should I repost a V2 or will the queuer fix it?

I'll fix it when I queue.

>
>
>
> --
> Pierre-Yves David
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel


More information about the Mercurial-devel mailing list