[PATCH 3 of 5] revset: avoid in loop lookup in _generatorset._consumegen

Pierre-Yves David pierre-yves.david at ens-lyon.org
Wed Sep 24 11:34:30 CDT 2014



On 09/24/2014 08:29 AM, Augie Fackler wrote:
> On Fri, Sep 19, 2014 at 03:33:56PM -0700, Pierre-Yves David wrote:
>> # HG changeset patch
>> # User Pierre-Yves David <pierre-yves.david at fb.com>
>> # Date 1398902208 25200
>> #      Wed Apr 30 16:56:48 2014 -0700
>> # Node ID a2b305e889547516d7952ee8ecd67948cd8ff360
>> # Parent  a38a9240a0c57afe2f4939f41a63382ef76b92fc
>> revset: avoid in loop lookup in _generatorset._consumegen
>>
>> Python lookup are slow, let do all lookup outside of the for loop.
>
> Queued first three. In 4 and 5, I think you mean "expensive" and not
> "expensible".

I do.

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list