[PATCH 1 of 4] obsolete: gather all contents related to format version 0 in a single place

Pierre-Yves David pierre-yves.david at ens-lyon.org
Wed Sep 24 11:40:21 CDT 2014



On 09/24/2014 08:21 AM, Augie Fackler wrote:
> On Tue, Sep 16, 2014 at 07:28:31PM -0700, Pierre-Yves David wrote:
>> # HG changeset patch
>> # User Pierre-Yves David <pierre-yves.david at fb.com>
>> # Date 1410525703 -7200
>> #      Fri Sep 12 14:41:43 2014 +0200
>> # Node ID d5f9d5cb72e220cc89661dbe08afd9b13436c1df
>> # Parent  48791c2bea1ceda4e4f28bc11651e281d636ce1a
>> obsolete: gather all contents related to format version 0 in a single place
>>
>> All contents embrances documentation, constants and functions. The diff is confusing
>
> Should "embrances" have been "enhances"? I'm not quite sure what word you meant.

Nope.

I mean "all content" ==  documentation + constants + functions.

Not sure what the word should be here.

>> because it cannot understand what code is semantically moved around in this
>> grand migration.
>
> I assume "no functionality change, just code movement" is true?

Yop

> This might be a case where a class-as-namespace would make some amount
> of sense, as much as I hate myself for the proposal.

Not sure. It is tempting but there is actually just a couple of function 
and an handful of constant. Not sure what the class would bring but the 
namespace. However the proposal makes sense and I tempted to do it. My 
plan it to discuss it with mpm in person next week.

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list