[PATCH 2 of 3] cmdserver: get file attributes of 'e'-channel from stdout, not from stderr

[Idan Kamara]

On Fri, Sep 26, 2014 at 9:31 PM, Yuya Nishihara <yuya at tcha.org> wrote:
> # HG changeset patch
> # User Yuya Nishihara <yuya at tcha.org>
> # Date 1411788423 -32400
> #      Sat Sep 27 12:27:03 2014 +0900
> # Node ID c1ab38c0a930e39eefaf6ffa794e3fa838b46dc5
> # Parent  5ee54fd7d942d4d6f6a315c4a6ccdfb6204c5ae4
> cmdserver: get file attributes of 'e'-channel from stdout, not from stderr
>
> It seems wrong to get attributes from object different than the underlying
> file.  In the following example, it doesn't make sense to flush stderr after
> writing to stdout:
>
>     self.ferr.write(str(a))
>     if not getattr(self.ferr, 'closed', False):
>         self.ferr.flush()

It took me a while to find that we use this pattern in ui.write_err,
but seems like a harmless and correct change.