[PATCH 3 of 3] cmdserver: drop useless in_ attribute from channeledoutput

Yuya Nishihara yuya at tcha.org
Sat Sep 27 21:33:37 CDT 2014


On Sat, 27 Sep 2014 15:47:56 -0700, Pierre-Yves David wrote:
> On 09/26/2014 09:31 PM, Yuya Nishihara wrote:
> > # HG changeset patch
> > # User Yuya Nishihara <yuya at tcha.org>
> > # Date 1411789073 -32400
> > #      Sat Sep 27 12:37:53 2014 +0900
> > # Node ID e5f8fa91ad36d260cc68e53e71c91883f608bc7a
> > # Parent  c1ab38c0a930e39eefaf6ffa794e3fa838b46dc5
> > cmdserver: drop useless in_ attribute from channeledoutput
> 
> Can you elaborate on why it is useless?

The previous patch makes sure that in_ == out, so it's no longer needed
to keep in_ for __getattr__.  Also, it seems strange for channeledoutput
to have in_ stream which is actually a writable file object.


More information about the Mercurial-devel mailing list