[PATCH 1 of 9] heredoctest: use the same dict for local/global contexts as in doctest

Yuya Nishihara yuya at tcha.org
Sun Sep 28 09:17:16 CDT 2014


# HG changeset patch
# User Yuya Nishihara <yuya at tcha.org>
# Date 1411881343 -32400
#      Sun Sep 28 14:15:43 2014 +0900
# Node ID 62ea66130006851da1973c55c6bfcb5bfbb7f856
# Parent  8cc5e673cac09bdfda15c229bf8165ab4a8a0721
heredoctest: use the same dict for local/global contexts as in doctest

In order to mimic module-level evaluation, globals and locals should be the
same object, so doctest does not pass separate locals dict.

https://docs.python.org/2.7/reference/simple_stmts.html#exec

This fixes NameError in the following example:

    >>> import foo
    >>> def bar():
    ...     foo  # must exist in globalvars

diff --git a/tests/heredoctest.py b/tests/heredoctest.py
--- a/tests/heredoctest.py
+++ b/tests/heredoctest.py
@@ -1,7 +1,6 @@
 import sys
 
 globalvars = {}
-localvars = {}
 lines = sys.stdin.readlines()
 while lines:
     l = lines.pop(0)
@@ -14,6 +13,6 @@ while lines:
             snippet += "\n" + l[4:]
         c = compile(snippet, '<heredoc>', 'single')
         try:
-            exec c in globalvars, localvars
+            exec c in globalvars
         except Exception, inst:
             print repr(inst)


More information about the Mercurial-devel mailing list