[PATCH 3 of 3] cmdserver: drop useless in_ attribute from channeledoutput

Yuya Nishihara yuya at tcha.org
Tue Sep 30 08:08:31 CDT 2014


On Mon, 29 Sep 2014 14:31:29 -0500, Matt Mackall wrote:
> On Sat, 2014-09-27 at 19:59 -0700, Pierre-Yves David wrote:
> > 
> > On 09/27/2014 07:33 PM, Yuya Nishihara wrote:
> > > The previous patch makes sure that in_ == out, so it's no longer needed
> > > to keep in_ for __getattr__.  Also, it seems strange for channeledoutput
> > > to have in_ stream which is actually a writable file object.
> > 
> > I augmented patch3 description with this paragraph and pushed the whole 
> > to clowncopter.
> 
> I think something may have broken on the buildbot here:
> 
> http://hgbuildbot.kublai.com/builders/python-hglib

Filed bug as
http://bz.selenic.com/show_bug.cgi?id=4396

python-hglib runs "hg log -r 'rev(n)'" to see if the revision exists or not.


More information about the Mercurial-devel mailing list