[PATCH 2 of 3] util: move dirs() and finddirs() from scmutil to util

Pierre-Yves David pierre-yves.david at ens-lyon.org
Tue Apr 7 13:13:04 CDT 2015



On 04/06/2015 03:48 PM, Drew Gottlieb wrote:
> # HG changeset patch
> # User Drew Gottlieb <drgott at google.com>
> # Date 1428356168 25200
> #      Mon Apr 06 14:36:08 2015 -0700
> # Node ID 3d7b11f525d9439dfdaae57bdaaf5a41ed4be5a9
> # Parent  51c4efb8fb03e7cfbbbbca87dac96aa43dc4f509
> util: move dirs() and finddirs() from scmutil to util
>
> An upcoming commit requires that match.py be able to call scmutil.dirs(), but
> when match.py imports scmutil, a dependency cycle is created. This commit
> avoids the cycle by moving dirs() and its related finddirs() function from
> scmutil to util, which match.py already depends on.\

pyflakes wish you a happy easter!

--- /home/marmoute/mercurial-testing/tests/test-check-pyflakes.t
+++ /home/marmoute/mercurial-testing/tests/test-check-pyflakes.t.err
@@ -7,6 +7,7 @@

    $ hg locate 'set:**.py or grep("^!#.*python")' 2>/dev/null \
    > | xargs pyflakes 2>/dev/null | "$TESTDIR/filterpyflakes.py"
+  mercurial/util.py:2249: undefined name 'util'
    tests/filterpyflakes.py:58: undefined name 'undefinedname'



ERROR: test-check-pyflakes.t output changed

This makes me a bit worried about the test coverage of this function…

(fixed while queuing)

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list