[PATCH 3 of 5] templatekw: change {manifest} to be empty for workingctx

Yuya Nishihara yuya at tcha.org
Wed Apr 8 06:08:59 CDT 2015


On Tue, 07 Apr 2015 11:27:59 -0700, Pierre-Yves David wrote:
> On 04/07/2015 09:42 AM, Sean Farley wrote:
> > Yuya Nishihara <yuya at tcha.org> writes:
> >> # HG changeset patch
> >> # User Yuya Nishihara <yuya at tcha.org>
> >> # Date 1426323498 -32400
> >> #      Sat Mar 14 17:58:18 2015 +0900
> >> # Node ID a019d816cc08bf16135e1e22c32eae56fc2d32da
> >> # Parent  8c44ed02f5ff82584e55c6978396ad004ec0dbe2
> >> templatekw: change {manifest} to be empty for workingctx
> >>
> >> This will prevent crash by "hg log -r 'wdir()' -Tdefault".
> >
> > Hmmm, I don't know how I feel about this. I would think the workingctx
> > manifest would be the parent manifest + added / removed files, no?
> > This would make it similar to how repo[None] works.
> 
> I second Sean here, this seems scary.

The {manifest} here is ctx.manifestnode(), not a list of files. I think you
are talking about ctx.manifest().

Regards,


More information about the Mercurial-devel mailing list