[PATCH 3 of 3] graft: record the user who performed the command in the extras dictionary
Matt Harbison
mharbison72 at gmail.com
Fri Apr 10 20:22:13 CDT 2015
On Fri, 10 Apr 2015 16:55:25 -0400, Matt Mackall <mpm at selenic.com> wrote:
> On Thu, 2015-04-09 at 23:38 -0400, Matt Harbison wrote:
>> # HG changeset patch
>> # User Matt Harbison <matt_harbison at yahoo.com>
>> # Date 1428635183 14400
>> # Thu Apr 09 23:06:23 2015 -0400
>> # Node ID 4ead5029e58ca8f2f85292fda0e372ca9086b113
>> # Parent ca0da0fe83538ab7cb6bc4a754cebbfe0a8c8520
>> graft: record the user who performed the command in the extras
>> dictionary
>>
>> Similar to the username stored with an obsolete marker, this comes only
>> from the
>> configured username or environment (i.e. -u is ignored). While not
>> unspoofable,
>> it should help provide additional forensic detail, without requiring the
>> developer to remember to specify -U. It's also not clear that
>> overwriting the
>> author attribute is appropriate in all environments.
>
> Seems reasonable.
>
>> Since there might be some automated systems that don't have a username
>> configured, just skip adding the field if it isn't available instead of
>> aborting.
>
> Awesome. Is this tested in the test suite? I can't spot it.
Nope. Added in V2.
More information about the Mercurial-devel
mailing list