[PATCH 2 of 2] shelve: acquire lock in the right order

Mon Apr 13 12:57:06 CDT 2015


On 04/13/2015 01:53 PM, Martin von Zweigbergk wrote:
>
> On Mon, Apr 13, 2015 at 10:30 AM Pierre-Yves David
> <pierre-yves.david at ens-lyon.org <mailto:pierre-yves.david at ens-lyon.org>>
> wrote:
>
>     # HG changeset patch
>     # User Pierre-Yves David <pierre-yves.david at fb.com
>     <mailto:pierre-yves.david at fb.com>>
>     # Date 1428865171 14400
>     #      Sun Apr 12 14:59:31 2015 -0400
>     # Node ID 7d10775076a3ca8ee7d3544112a83483313905c8
>     # Parent  55c24d69aea7ec2690dee8ff0111112c85d8dfaa
>     shelve: acquire lock in the right order
>
>     Text book says that 'wlock' should be acquired before 'lock'.
>
>
> Where is the text book? I looked at localrepo.(w)lock() and it didn't
> mention anything. Should it?

Somewhere http://mercurial.selenic.com/wiki/LockingDesign

-- 
Pierre-Yves David