[PATCH STABLE] tests: use double quote to quote arguments in hook for portability
FUJIWARA Katsunori
foozy at lares.dti.ne.jp
Thu Apr 23 13:41:14 UTC 2015
# HG changeset patch
# User FUJIWARA Katsunori <foozy at lares.dti.ne.jp>
# Date 1429796361 -32400
# Thu Apr 23 22:39:21 2015 +0900
# Branch stable
# Node ID f256ddec4b2cb02c3384b634bcfbb2358ce07efe
# Parent 1f9127c9239b9c39c676bb09752db1e2ca6c26f7
tests: use double quote to quote arguments in hook for portability
On windows, single quote doesn't work as quote character in hook
command line, because "cmd.exe" doesn't recognize it as quoting
character. And this causes failure of test.
This patch uses double quote to quote arguments in hook instead of
single quote for portability.
Even though single quotes for "[hooks] pretxncommit" in
test-clone-pull-corruption.t seems to work correctly (may MinGW sh
treat specially ?) AFAIK, this patch also replaces them by double
quotes for consistency.
diff --git a/tests/test-clone-pull-corruption.t b/tests/test-clone-pull-corruption.t
--- a/tests/test-clone-pull-corruption.t
+++ b/tests/test-clone-pull-corruption.t
@@ -16,7 +16,7 @@ Add a hook to wait 5 seconds and then ab
$ cd ../corrupted
$ echo "[hooks]" >> .hg/hgrc
- $ echo "pretxncommit = sh -c 'sleep 5; exit 1'" >> .hg/hgrc
+ $ echo 'pretxncommit = sh -c "sleep 5; exit 1"' >> .hg/hgrc
start a commit...
diff --git a/tests/test-pending.t b/tests/test-pending.t
--- a/tests/test-pending.t
+++ b/tests/test-pending.t
@@ -120,7 +120,7 @@ Test that pending on transaction without
$ cat <<EOF > parent/.hg/hgrc
> [hooks]
> pretxnchangegroup=
- > pretxnclose = hg tip -T 'tip: {node|short}\n'
+ > pretxnclose = hg tip -T "tip: {node|short}\n"
> [phases]
> publishing=False
> EOF
More information about the Mercurial-devel
mailing list