[PATCH 1 of 2 STABLE] test-command-template: test the phase template more precisely

Matt Mackall mpm at selenic.com
Mon Apr 27 18:09:38 CDT 2015


On Mon, 2015-04-27 at 15:43 -0400, Jordi GutiƩrrez Hermoso wrote:
> # HG changeset patch
> # User Jordi GutiƩrrez Hermoso <jordigh at octave.org>
> # Date 1430069977 14400
> #      Sun Apr 26 13:39:37 2015 -0400
> # Branch stable
> # Node ID 51729c1c3810795e9f1ab3f1cd45b3539580b4b0
> # Parent  bff42a92012e49aabd925caa3cb243116285e243
> test-command-template: test the phase template more precisely
> 
> The current test that greps for "phase:" only checks that the word
> "phase" is in the output, but does not test that nothing else gets
> added by this template. This improves these tests by showing a unified
> diff with 0 context for brevity while at the same time grepping out
> the header, which has an irrelevant timestamp.

Let's revisit this after the freeze, please. Stable (and the code
freeze) are about maximizing the benefit/risk ratio of changes for end
users. Patches with both tiny benefit and risk don't score well in that
metric.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list