[PATCH] convert: fix git convert using servers branches
Siddharth Agarwal
sid at less-broken.com
Tue Aug 4 19:58:35 CDT 2015
On 8/4/15 5:40 PM, Pierre-Yves David wrote:
>
>
> On 08/03/2015 11:44 AM, Durham Goode wrote:
>> # HG changeset patch
>> # User Durham Goode <durham at fb.com>
>> # Date 1438201263 25200
>> # Wed Jul 29 13:21:03 2015 -0700
>> # Branch stable
>> # Node ID e50c7d78fa48814dde3a99454766f48994036db0
>> # Parent 79f0cb97d7537a7c2948f8f9b0a89148825a3a1d
>> convert: fix git convert using servers branches
>
> That patch looks good to me, can I get a second green flag from
> someone who know something about "git show-ref".
Yeah, lgtm
>
> […]
>
>> - name = '%s%s' % (reftype, name[prefixlen:])
>> + name = '%s%s' % (hgprefix, name[len(gitprefix):])
>> bookmarks[name] = rev
>> - except Exception:
>> - pass
>> + except Exception:
>> + pass
>
> Not sure why this is for, but this is pretty scary.
> (I know, not your change)
>
>
>
More information about the Mercurial-devel
mailing list