[PATCH] parsers: fix memory leak in compute_phases_map_sets

Bryan O'Sullivan bos at serpentine.com
Fri Aug 7 05:58:07 CDT 2015


On Fri, Aug 7, 2015 at 11:41 AM, Bryan O'Sullivan <bos at serpentine.com>
wrote:

> On Fri, Aug 7, 2015 at 7:01 AM, Laurent Charignon <lcharignon at fb.com>
> wrote:
>
>> +                       rev = PyInt_FromLong(i);
>>
>
> You forgot to check the return value for NULL.
>

I should say: whoever originally wrote the code forgot to check for NULL,
and you preserved the bug :-)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20150807/28731f2f/attachment.html>


More information about the Mercurial-devel mailing list