[PATCH] parsers.c: avoid implicit conversion loses integer precision warnings

Yuya Nishihara yuya at tcha.org
Tue Aug 18 09:30:29 CDT 2015


On Tue, 18 Aug 2015 14:59:47 +0200, André Sintzoff wrote:
> # HG changeset patch
> # User André Sintzoff <andre.sintzoff at gmail.com>
> # Date 1439902654 -7200
> #      Tue Aug 18 14:57:34 2015 +0200
> # Node ID 99bbcbd8b97420e8a473d0e5f16242625f6ec04c
> # Parent  9e7d805925c87cfa0ca30819e8273ac37fd77a62
> parsers.c: avoid implicit conversion loses integer precision warnings
> 
> These warnings are raised by Apple LLVM version 6.1.0 (clang-602.0.53)
> (based on LLVM 3.6.0svn) and were introduced in ff89383a97db
> 
> diff -r 9e7d805925c8 -r 99bbcbd8b974 mercurial/parsers.c
> --- a/mercurial/parsers.c	Fri Aug 14 12:36:41 2015 +0900
> +++ b/mercurial/parsers.c	Tue Aug 18 14:57:34 2015 +0200
> @@ -1109,7 +1109,7 @@
>  {
>  
>  	/* Input */
> -	long minroot;
> +	int minroot;

minroot should be long because it is output argument of PyArg_ParseTuple(),
or should it be specified as "i" type?


More information about the Mercurial-devel mailing list