[PATCH 7 of 7] reachableroots: return list of revisions instead of set

[Sean Farley]

Yuya Nishihara <yuya at tcha.org> writes:

> # HG changeset patch
> # User Yuya Nishihara <yuya at tcha.org>
> # Date 1439535139 -32400
> #      Fri Aug 14 15:52:19 2015 +0900
> # Node ID bd9eecaa3c297c59cf0e558672b2564ef8268d02
> # Parent  9a0ff0541db15438c019d5a3db6184c84c6b4c25
> reachableroots: return list of revisions instead of set
>
> Now we don't need a set of reachable revisions, and the caller wants a sorted
> list of revisions, so constructing a set is just a waste of time.
>
>   revset #0: 0::tip
>   2) 0.002536
>   3) 0.001598  63%
>
> PyList_New() should set an appropriate exception on error, so we don't need
> to call PyErr_NoMemory() manually.
>
> This patch lacks error handling of PyList_Append() as it was before for
> PySet_Add(). It should be fixed later.

This series looks fine to me but I don't know about the question of
renaming the function due to its signature changing.