[PATCH 4 of 6 cpychecker] parsers: drop spurious check of readlen value

Augie Fackler raf at durin42.com
Tue Aug 18 16:54:14 CDT 2015


# HG changeset patch
# User Augie Fackler <augie at google.com>
# Date 1439930366 14400
#      Tue Aug 18 16:39:26 2015 -0400
# Node ID 2c553a1aae96d666002313c6c04acda080eaeff4
# Parent  ec2dee7d4778fc4bc46dff6a74e5af26a99cadb5
parsers: drop spurious check of readlen value

We're about to check if len < 40 after assigning readlen to len, which
means that if len < 40 we'll still abort, but I'm about to add a
sensible exception to that failure, so let's just discard this useless
check.

diff --git a/mercurial/parsers.c b/mercurial/parsers.c
--- a/mercurial/parsers.c
+++ b/mercurial/parsers.c
@@ -478,9 +478,6 @@ static PyObject *parse_dirstate(PyObject
 			      &str, &readlen))
 		goto quit;
 
-	if (readlen < 0)
-		goto quit;
-
 	len = readlen;
 
 	/* read parents */


More information about the Mercurial-devel mailing list