[Bug 4788] New: Mercurial 3.5 no longer attributes remote hook failures to remote

[mercurial-bugs at selenic.com]

http://bz.selenic.com/show_bug.cgi?id=4788

          Priority: normal
            Bug ID: 4788
                CC: mercurial-devel at selenic.com,
                    pierre-yves.david at ens-lyon.org
          Assignee: bugzilla at selenic.com
           Summary: Mercurial 3.5 no longer attributes remote hook
                    failures to remote
          Severity: bug
    Classification: Unclassified
                OS: All
          Reporter: gregory.szorc at gmail.com
          Hardware: All
            Status: UNCONFIRMED
           Version: 3.5
         Component: bundle2
           Product: Mercurial

It looks like Mercurial 3.5 (accidentally?) changed how remote aborts are
reported. The following is a diff of the test at
https://hg.mozilla.org/hgcustom/version-control-tools/file/1ae8089c9835/hgext/pushlog/tests/test-permissions.t#l45
between Mercurial 3.4.1 and 3.5/@.

@@ -59,5 +59,5 @@
   remote: transaction abort!
   remote: rolling back pushlog
   remote: rollback completed
-  remote: abort: pretxnchangegroup.pushlog hook failed
-  [1]
+  abort: pretxnchangegroup.pushlog hook failed
+  [255]

I think the old behavior of prefixing the "abort:" with "remote:" was correct,
as the abort occurs on the remote side, not the local side.

I suspect this has something to do with bundle2.

-- 
You are receiving this mail because:
You are on the CC list for the bug.