[PATCH 5 of 7] reachableroots: use internal "revstates" array to test if rev is a root

Augie Fackler raf at durin42.com
Fri Aug 21 18:07:05 CDT 2015


> On Aug 21, 2015, at 7:05 PM, Pierre-Yves David <pierre-yves.david at ens-lyon.org> wrote:
> 
> On 08/21/2015 10:48 AM, Augie Fackler wrote:
>> On Tue, Aug 18, 2015 at 11:42:57PM +0900, Yuya Nishihara wrote:
>>> # HG changeset patch
>>> # User Yuya Nishihara <yuya at tcha.org>
>>> # Date 1439534609 -32400
>>> #      Fri Aug 14 15:43:29 2015 +0900
>>> # Node ID 93e5cd30d2ff9b63f11616054cb647d6ac998053
>>> # Parent  2ca0b48b6de1c79bc205e7a660a5531c125cad9e
>>> reachableroots: use internal "revstates" array to test if rev is a root
>> 
>> After squinting briefly with mpm, I'm going to rename the
>> reachableroots c func to reachableroots2 and queue this. Thanks!
> 
> If we break the function signature, can we do so with iterable instead of list ?

I believe that will require us to perform significantly more bookkeeping than doing the list thing. We can always break it again, it’s not like it’s expensive.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20150821/f2aff392/attachment.pgp>


More information about the Mercurial-devel mailing list