Fwd: [PATCH] revsets: makes follow() supports file patterns (issue4757)

Piotr Listkiewicz piotr.listkiewicz at gmail.com
Mon Aug 24 11:05:13 CDT 2015


---------- Forwarded message ----------
From: Piotr Listkiewicz <piotr.listkiewicz at gmail.com>
Date: 2015-08-24 18:03 GMT+02:00
Subject: Re: [PATCH] revsets: makes follow() supports file patterns
(issue4757)
To: Yuya Nishihara <yuya at tcha.org>


> cwd should be repo.getcwd() to handle relative paths.

This behaviour seem more reasonable, but then it will not preserve current
behaviour of follow which was point of discussion so far, in old version of
follow :

>      c = repo['.']
>      if l:
> -        x = getstring(l[0], _("%s expected a filename") % name)
> -        if x in c:

Matching files was done against repository root( x in c) , not taking into
consideration current working directory.

> My question was, why ctx=wctx instead of ctx=c ?
> I might be wrong, but I couldn't figure out the need of wctx.

When we supply ctx=c patterns like 'set:clean' will not work.

> Comment removed unexpectedly?

You are right sir :P
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20150824/fd865add/attachment.html>


More information about the Mercurial-devel mailing list