Fwd: [PATCH] revsets: makes follow() supports file patterns (issue4757)

Yuya Nishihara yuya at tcha.org
Tue Aug 25 07:22:39 CDT 2015


On Mon, 24 Aug 2015 18:05:13 +0200, Piotr Listkiewicz wrote:
> > cwd should be repo.getcwd() to handle relative paths.
> 
> This behaviour seem more reasonable, but then it will not preserve current
> behaviour of follow which was point of discussion so far, in old version of
> follow :

That's the reason we have to use default='path' instead of default='glob' or
'relpath'.

Note: Personally I prefer default='glob' (i.e. relative path) if the behavior
change is acceptable.

> > My question was, why ctx=wctx instead of ctx=c ?
> > I might be wrong, but I couldn't figure out the need of wctx.
> 
> When we supply ctx=c patterns like 'set:clean' will not work.

Good point. "file(pattern)" revset behaves as such since 3.2.
Can you add the test for set:clean() ?


More information about the Mercurial-devel mailing list