[PATCH 1 of 2 obs-speedup] obsolete: add C implementation of _addsuccessors

Augie Fackler raf at durin42.com
Wed Aug 26 09:12:25 CDT 2015


On Wed, Aug 26, 2015 at 10:09 AM, Augie Fackler <raf at durin42.com> wrote:
>>
>> I'm kind of loathe to accept C code that isn't at least 4x or so faster
>> than what it's replacing, but this 10% doesn't measure that directly.
>> Can I get you to tweak perf.py to do that?
>
> If my perf patch is right, this code didn't make much difference.
>
> Before:
> ! wall 0.074395 comb 0.080000 user 0.070000 sys 0.010000 (best of 100)
>
> After:
> ! wall 0.067937 comb 0.070000 user 0.070000 sys 0.000000 (best of 100)
>
> So I guess we must be calling addsuccessors a lot of times or something.


Or I'm just crazy. We definitely only call the function once, and I no
longer see a significant win using hgperf. Sorry for the noise.


More information about the Mercurial-devel mailing list