[PATCH 1 of 2 evolve-ext] inhibit: update test with new behavior from core

Pierre-Yves David pierre-yves.david at ens-lyon.org
Tue Dec 1 08:14:27 UTC 2015



On 11/24/2015 05:19 PM, Laurent Charignon wrote:
> # HG changeset patch
> # User Laurent Charignon <lcharignon at fb.com>
> # Date 1448414175 28800
> #      Tue Nov 24 17:16:15 2015 -0800
> # Node ID 6d694642bfce2d39320f5f1b1d354e902b7fc39c
> # Parent  48547b4c77defdd17c670b1eb0eb94272edf0207
> inhibit: update test with new behavior from core
>
> The recent changes in core (to make sure that all bookmarks write are done at
> the end of a transaction) changed the behavior of inhibit. When one rebases
> a set of hidden revs somewhere, the hidden revs become visible at the end of
> the rebase. Both the previous behavior and new behavior seems acceptable but
> the tests have to be changed subsequently. This patch modifies one of the test
> for inhibit when the case mentioned above happens. We prune the revs inhibited
> by the rebase to make the change minimal.

Please document in the test that this rebase is covering for a bug and 
why the bug is acceptable. So that if we fix the fixer does not get 
puzzled at the bug failure.

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list