[PATCH] histedit: pick an appropriate base changeset by default (BC)

Pierre-Yves David pierre-yves.david at ens-lyon.org
Tue Dec 1 11:25:08 CST 2015



On 12/01/2015 06:49 AM, Augie Fackler wrote:
> On Mon, Nov 30, 2015 at 09:21:11AM -0800, Pierre-Yves David wrote:
>>
>>
>> On 11/25/2015 12:37 AM, Gregory Szorc wrote:
>>> # HG changeset patch
>>> # User Gregory Szorc <gregory.szorc at gmail.com>
>>> # Date 1445712999 -3600
>>> #      Sat Oct 24 19:56:39 2015 +0100
>>> # Node ID e76c43d21b1c92da903fc8c8b2887ce1926c1463
>>> # Parent  61fbf5dc12b23e7a2a30cf04ebd9f096c42a1f61
>>> histedit: pick an appropriate base changeset by default (BC)
>>>
>>> Previously, `hg histedit` required a revision argument specifying which
>>> revision to use as the base for the current histedit operation. There
>>> was an undocumented and experimental "histedit.defaultrev" option that
>>> supported defining a single revision to be used if no argument is
>>> passed.
>>
>> The whole effort of making histedit having better default is great. (Good
>> default arguments are awesome).
>>
>> However, can you make sure this new default is easily overridable by the
>> various extensions playing around with the concept of stack. See the work
>> done in destutil.py and the similar work in rebase.py.
>
> I just remembered that it's important for the planned work on topics
> etc to be able to override this, so a big +1 on getting this behavior
> hoisted out in destutil as something that's easy to wrap.

Having it in destutil is not an heavy requirement. Rebase offer an easy 
hook point while still being in evolve.

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list