[PATCH 2 of 2] bookmarks: make bookmarks.write deprecated

Pierre-Yves David pierre-yves.david at ens-lyon.org
Tue Dec 1 12:23:19 CST 2015



On 12/01/2015 07:12 AM, Augie Fackler wrote:
> On Mon, Nov 30, 2015 at 04:52:58PM -0800, Laurent Charignon wrote:
>> # HG changeset patch
>> # User Laurent Charignon <lcharignon at fb.com>
>> # Date 1448930318 28800
>> #      Mon Nov 30 16:38:38 2015 -0800
>> # Node ID 4c08a53f244a78832ad01a59fe495a2ba0c352e8
>> # Parent  dd44f8f830cab6059f5cc82e4d4b496bac8dce38
>> bookmarks: make bookmarks.write deprecated
>
> I've queued the first patch, but I think I'd like to see the rest of
> mq and rebase cleaned up before we take this patch.
>
> My strong preference would be to remove bookmarks.write() and instead
> proactively break extensions that are monkeying with bookmarks over a
> devel warning. Is there a compelling reason to do the warning?

If we can avoid a dozen of extension to get gratuitously broken that 
would be none. I would rather give them a cycle or two of tests yelling 
at them to adjust their code.

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list