record / crecord config options cleanup proposal

Augie Fackler raf at durin42.com
Wed Dec 2 12:37:17 CST 2015


> On Dec 2, 2015, at 1:28 PM, Laurent Charignon <lcharignon at fb.com> wrote:
> 
>>> Proposed changes:
>>> -----------------
>>> 
>>> 1) Make crecord no longer an experimental feature but the default
>>> interface relying on a config called ui.cursesinteractiveselection
>>> that can be set to auto/yes/no.  auto would be the default value.
>>> If the user picks "auto" and curses is not available, record's
>>> interface would be use instead.
>> 
>> I'm -0.5 on curses being the /default/ interface for commit
>> --interactive if the (eventual) goal is to mark record as a deprecated
>> extension/command name (which I'd like to do). Right now it's *WAY*
>> too hard to disable curses when it's going to be inconvenient (I have
>> an ugly alias [0] for when I want crecord, precisely because this is
>> so cumbersome.)
>> 
>> 0: https://urldefense.proofpoint.com/v2/url?u=https-3A__bitbucket.org_durin42_dotfiles_commits_7fa854682fdd225197c5fa392ded7110d44cf482&d=CwIBAg&c=5VD0RTtNlTh3ycd41b3MUw&r=qmwlQ6ljsf0--v3ANP53-V-RM6PPUtJ5zK5Y1fStJGg&m=UslUop3Joh-uTQtE5OGge6jJMD-143cO6eUIPQfhtbk&s=qN6rrNsQ1Qbogxlk38pibs1POHgBBymp3OVgMBtd88U&e=
> 
> So what do you suggest doing instead?

Not defaulting to curses is top of mind, I don’t have a good proposal offhand for making it easy to pick curses/not on an adhoc basis. If we had the latter, then I’d be happier with some kind of curses default as long as it’s clear how to disable use of curses most of the time.

AF

> 
>> 
>> 
>>> If the user picks "yes" and curses is not available, we would print an error.
>>> 
>>> 2) Get rid of revert.revertalternateinteractivemode and keep its
>>> default value to match what hg diff returns.  This was the idea
>>> supported by Pierre-Yves and most people seemed to agree with it.
>>> 
>>> 3) Keep experimental.crecordtest as is
>> 
>> +1>
>> 
>>> 
>>> 4) Send a patch to the crecord maintainer to use the option proposed
>>> in 1) and use core's implementation as of the next release of
>>> mercurial.  This way, we will avoid further breakage like the one
>>> that happened recently.
>> 
>> Alternatively, if crecord is in mainline now, why not have crecord
>> poison-pill itself if it sees a recent hg?


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20151202/ce777229/attachment.pgp>


More information about the Mercurial-devel mailing list