[PATCH] histedit: pick an appropriate base changeset by default (BC)

[Gregory Szorc]

On Wed, Nov 25, 2015 at 9:10 AM, Durham Goode <durham at fb.com> wrote:

>
>
> On 11/25/15 8:42 AM, Augie Fackler wrote:
>
>> On Nov 25, 2015, at 3:37 AM, Gregory Szorc <gregory.szorc at gmail.com>
>>> wrote:
>>>
>>> +                histeditdefault = ui.config('histedit', 'defaultrev',
>>> +                        'first(only(.) and not public() and not
>>> ::merge())')
>>>
>> Durham, how does this compare to what FBers get from your stuff? Do you
>> have any sense of how it’s better or worse?
>>
> It's basically the same as what we have ("limit(only(.) & draft(), 50)").
> We also add a limit of 50 commits, just to keep things from going too
> crazy.  We also don't use the ::merge() bit, I forget why (maybe for perf
> reasons?).
>

If this is what you have, isn't it buggy? "only(.) & draft()" will return
in increasing revisions changesets in the current DAG head. limit() will
slice from base towards tip. But since the first revision is used, it will
be the base-most changeset. I think you need to do "limit(reverse(only(.) &
draft()), 50)".
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20151203/427c05cd/attachment.html>