[PATCH 3 of 3] commands: add debugdeltachain command

[Pierre-Yves David]

On 12/06/2015 12:45 AM, Gregory Szorc wrote:
> # HG changeset patch
> # User Gregory Szorc <gregory.szorc at gmail.com>
> # Date 1449387466 28800
> #      Sat Dec 05 23:37:46 2015 -0800
> # Node ID 5e40f33ca9aad630d6a75f73bbcc5f8fdad3cd01
> # Parent  860794fcdaf0794f1f08d1620f0421d1eec96b6d
> commands: add debugdeltachain command

Pretty nice.
I've pushed the first 2.

This kind of output would probably deserve a json output (by using a 
formater), but this can come later. This would allow to easily script 
analysis of the yielded data.

[...]
> +        ui.write('{rev:>7d} {chainidx:>7d} {chainlen:>8d} {prevrev:>8d} '
> +                 '{deltatype:>7s} {compsize:>10d} {uncompsize:>10d} '
> +                 '{chainsize:>10d} {chainratio:>9.5f} {lindist:>9d} '
> +                 '{extradist:>9d} {extraratio:>10.5f}\n'
> +                 .format(
> +                     rev=rev,
> +                     chainidx=chainidx,
> +                     chainlen=len(chain),
> +                     prevrev=prevrev,
> +                     deltatype=deltatype,
> +                     compsize=comp,
> +                     uncompsize=uncomp,
> +                     chainsize=chainsize,
> +                     chainratio=chainratio,
> +                     lindist=lineardist,
> +                     extradist=extradist,
> +                     extraratio=extraratio))

Nice attempt to introduce .format() call into the code base by working 
around the check-code check, but you got caught.

Please challenge the check-code rules and justify an exception.

Cheers,

-- 
Pierre-Yves David