[PATCH] exchange: identify the troubled commit

Sean Farley sean at farley.io
Mon Dec 7 23:05:28 CST 2015


timeless <timeless at mozdev.org> writes:

> # HG changeset patch
> # User timeless <timeless at mozdev.org>
> # Date 1449549446 0
> #      Tue Dec 08 04:37:26 2015 +0000
> # Node ID 7835c3c8bf67c5213c21276645442e21e4180b7d
> # Parent  42aa0e570eaa364a622bc4443b0bcb79b1100a58
> exchange: identify the troubled commit
>
> Exchange iterates over heads to quickly identify if everything is
> OK. But, users don't want to know the revision of the bad head,
> they need to know the revision of the bad commit.
>
> So, instead of identifying the faulty head, once we know there's
> a faulty head, iterate over all of outgoing and identify the
> specific commit that is troubled.
>
> This could be improved by only looking at revisions relating to
> the faulty head. But, since we're already failing, there's no real
> need for an optimized algorithm.

I tend to agree with timeless here. While we can bikeshed more here, I
think this is a step in the right direction. Thoughts from others?


More information about the Mercurial-devel mailing list