[PATCH 2 of 2 V2] setup.py: don't rewrite @LIBDIR@ when creating wheels
Yuya Nishihara
yuya at tcha.org
Tue Dec 8 06:40:11 CST 2015
On Mon, 7 Dec 2015 17:39:58 -0500, Gregory Szorc wrote:
> > On Dec 7, 2015, at 08:38, Yuya Nishihara <yuya at tcha.org> wrote:
> >
> >> On Sun, 06 Dec 2015 14:18:30 -0800, Gregory Szorc wrote:
> >> # HG changeset patch
> >> # User Gregory Szorc <gregory.szorc at gmail.com>
> >> # Date 1449366770 28800
> >> # Sat Dec 05 17:52:50 2015 -0800
> >> # Node ID 43a7531c00902c4be3acab314d1fbb24136a047e
> >> # Parent b47041dfe62151571ed6a9d8e9271b3924a2d80f
> >
> > Pushed to the clowncopter, thanks.
> >
> >> if b('\0') in data:
> >> continue
> >>
> >> + # During local installs, the shebang will be rewritten to the final
> >> + # install path. During wheel packaging, the shebang has a special
> >> + # value.
> >> + if data.startswith(b'#!python'):
> >
> > I noticed we use b(...) in setup.py, but it won't be necessary since we've
> > dropped support for Python < 2.6.
>
> I think this is for Python 3 compatibility. Without it, we'd be comparing
> a bytes wth a str, which isn't allowed.
Yes, and we can use b'...' instead of b(...) now.
More information about the Mercurial-devel
mailing list