[PATCH] histedit: delete to drop

Durham Goode durham at fb.com
Thu Dec 10 12:11:01 CST 2015



On 12/9/15 7:20 PM, timeless wrote:
> fwiw. I'd prefer a mode where if the user omits lines, we re-present
> the editor w/ their commands and a set of "drops" at the end of the
> list for all of the changesets they omitted and ask them to confirm.
>
> While it might be a bit annoying to get a second editor, it's a lot
> clearer and gives people a chance to verify that they did what they
> intended. Which avoids the footgun.
>
I think our emphasis on preventing users from shooting themselves in the 
foot is misplaced.  We should put an emphasis on making undo's easy and 
discoverable. It's like all the dialogs in the old Outlook asking 'are 
you sure you want to delete these emails?', then gmail comes along and 
just offers an 'undo' button and all those annoying dialogs go away.

Histedit is a powerful command, and there's an infinite number of ways 
people can shoot themselves, but it would be pretty trivial to print the 
'hg unbundle .hg/strip-backups/... && hg update <hash>' command the user 
must run to undo the operation. This would allow power users to go about 
their business, and provide a discovery path for understanding how hg 
backups work.


More information about the Mercurial-devel mailing list