[PATCH remotefilelog-ext] Reuse ssh connection across miss fetches

[Augie Fackler]

On Fri, Dec 11, 2015 at 12:22 PM, Durham Goode <durham at fb.com> wrote:
>> What's up with the sshpeer.sshpeer isinstance checks? Nothing else is
>> assigning to this attribute right now, so it shouldn't matter...
>
> The http peer is also stored in self.remoteserver, so the http tests fails
> without that check.


Ah. That's a little groty. I think where I'd go with this is look for
self.remoteserver.cleanup() and call that if it exists in the
teardown.

I'm less sure what to do about the bit where we ensure the connection
is alive - perhaps we should expand the peer API to include something
useful on that front instead of just having random isinstance checks
sprinkled in various bits of code. That's more of an idea for later, I
guess, but it seems like something we should clean up before too long.