[PATCH 1 of 4] parsers: simplify error logic in compute_phases_map_sets

Augie Fackler raf at durin42.com
Tue Dec 15 12:17:57 CST 2015


On Wed, Dec 16, 2015 at 12:32:24AM +0900, Yuya Nishihara wrote:
> On Mon, 14 Dec 2015 10:49:22 -0800, Bryan O'Sullivan wrote:
> > # HG changeset patch
> > # User Bryan O'Sullivan <bos at serpentine.com>
> > # Date 1450118844 28800
> > #      Mon Dec 14 10:47:24 2015 -0800
> > # Node ID f87799029bb6c39860b9eede0ae54a8dfece8c01
> > # Parent  944af8e2eb4cddf96ba5b8a96854528b40979715
> > parsers: simplify error logic in compute_phases_map_sets
> >
> > Since Py_XDECREF and free both accept NULL pointers, we can get by
> > with just two exit paths: one for success, and one for error.
> >
> > This considerably simplifies reasoning about the possible ways to
> > exit from this function.
>
> I'll push 1, 2 and 4 to the clowncopter tomorrow, thanks!

Per your review, I'm queueing these (they're not yet on the
clowncopter) and will push them shortly. Thanks!


> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> https://selenic.com/mailman/listinfo/mercurial-devel


More information about the Mercurial-devel mailing list