[PATCH 4 of 4] tests: add coverage to ensure Wix tracks 'help' and 'templates' files

Yuya Nishihara yuya at tcha.org
Thu Dec 17 06:51:13 CST 2015


On Sun, 13 Dec 2015 22:37:59 -0500, Matt Harbison wrote:
> On Sun, 13 Dec 2015 21:56:42 -0500, Matt Harbison <mharbison72 at gmail.com>  
> > +  > def hgdirectory(relpath):
> > +  >     '''generator of tracked files, rooted at relpath'''
> > +  >     hgdir = "%s/../mercurial" % (testdir)
> > +  >     args = ['hg', '--cwd', hgdir, 'files', '--rev', '.', relpath]
> 
> Do we want to check . or wdir()?  The test didn't catch it when I imported  
> Greg's first doc patch without committing it.  But I tend to commit/amend  
> often, and run the tests on a fully committed repo.  That's needed anyway  
> to commit comment checking, etc.  Not sure if there's an existing  
> philosophy for this kind of thing.

Perhaps wdir. Tests can be run without committing, and the other similar tests
use "hg locate" or "hg files" with no -r option.

By the way, this would need '#if test-repo'.


More information about the Mercurial-devel mailing list